This repository has been archived by the owner on Jul 25, 2024. It is now read-only.
frontend/templatetags: Add handling for missing status #1107
+36
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
katieworton
force-pushed
the
project_status_error
branch
from
c4af18b
to
df3a171
Compare
|
@chaws Let me know how this looks 👍 |
chaws
reviewed
Oct 16, 2023
bhcopeland
reviewed
Oct 18, 2023
If status was missing, this would previously cause a 500 error when loading the page, due to a RelatedObjectDoesNotExist error being raised when the project status function was called. Now, add handling for the case where status is None, so the project_status will return None instead of raising an error. Signed-off-by: Katie Worton <[email protected]>
katieworton
force-pushed
the
project_status_error
branch
from
df3a171
to
3ec5e6f
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If status was missing, this would previously cause a 500 error when loading the page, due to a RelatedObjectDoesNotExist error being raised when the project status function was called.
Now, add handling for the case where status is None, so the project_status will return None instead of raising an error.